Refactor and bug fix#60
Conversation
|
Wow those are a lot of changes. |
This way we have a centralized module from which to `import` common functionality
Also add more type annotations
Yeah lol. I'm almost done (I guess). Don't worry, I'll try to keep the diff small (for easier review) |
|
I realized using a keyword |
|
You are right lol. I did not put effort in code optimization, sorry for causing this inconvenience. Thank you for making these changes, I appreciate your hard work! |
I wrote the comment as "imperative", but I changed it to "explanatory", to be a note targeted to everyone (code-owners and contributors alike)
Fixed a `KW.GOE_OP` where a `KW.G_OP` should be. Added some more type annotations. Formatted some stuff. Moved a `dict` assignment outside of a branch (for performance, and potential reuse in the future)
|
Yes, it is better if you finish everything in one PR lol, and after this change, I will merge it. |
|
Ok lol. I'm gonna speedrun this! (it's a joke, don't worry lol, I'll take my time to avoid more mistakes) |
I guess
|
@SatinWuker it's ready! Please give me feedback, there might be places where it may be better to revert changes (like making a type annotation less verbose, or formatting in a different way, etc...). There may be bugs/mistakes, but I "triple-checked", so it's unlikely, lol |
|
Thank you! Those are some huge changes lol, I am merging it. |
enums to get the benefits from vars anddictsFinalannotations to avoid accidental assignment of immutable vars (also to reduce cognitive load of managing global vars)Disclaimer: I tested most (not all) of the changes