Fix: Remove illegal characters before returning to reserved list#1683
Merged
RicoSuter merged 1 commit intoJun 12, 2024
Merged
Conversation
This was referenced Oct 16, 2025
This was referenced Oct 24, 2025
This was referenced Nov 4, 2025
This was referenced Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem, that multiple same-named types was generated and only the first wins. Thats when a illegal character was removed. The reserved list was comparing to the type name WITH the illegal character, but the type name was stored WITHOUT the illegal character - and so couldn't find a match.