Skip to content

Use TypeScript 4.3 as default testing version #5234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lahma merged 1 commit into from
Aug 1, 2025
Merged

Use TypeScript 4.3 as default testing version #5234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/NSwag.CodeGeneration.TypeScript.Tests/AngularJSTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,14 +50,15 @@ public async Task When_export_types_is_true_then_add_export_before_classes()
GenerateClientInterfaces = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m,
TypeScriptVersion = 4.3m,
ExportTypes = true
}
});
var code = codeGen.GenerateFile();

// Assert
await VerifyHelper.Verify(code);
TypeScriptCompiler.AssertCompile(code);
}

[Fact]
Expand All @@ -80,14 +81,15 @@ public async Task When_export_types_is_false_then_dont_add_export_before_classes
GenerateClientInterfaces = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m,
TypeScriptVersion = 4.3m,
ExportTypes = false
}
});
var code = codeGen.GenerateFile();

// Assert
await VerifyHelper.Verify(code);
TypeScriptCompiler.AssertCompile(code);
}

[Fact]
Expand All @@ -108,13 +110,14 @@ public async Task When_consumes_is_url_encoded_then_construct_url_encoded_reques
Template = TypeScriptTemplate.AngularJS,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m
TypeScriptVersion = 4.3m
}
});
var code = codeGen.GenerateFile();

// Assert
await VerifyHelper.Verify(code);
TypeScriptCompiler.AssertCompile(code);
}
}
}
10 changes: 5 additions & 5 deletions src/NSwag.CodeGeneration.TypeScript.Tests/AngularTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public async Task When_return_value_is_void_then_client_returns_observable_of_vo
GenerateClientInterfaces = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m
TypeScriptVersion = 4.3m
}
});
var code = codeGen.GenerateFile();
Expand Down Expand Up @@ -118,7 +118,7 @@ public async Task When_export_types_is_true_then_add_export_before_classes()
GenerateClientInterfaces = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m,
TypeScriptVersion = 4.3m,
ExportTypes = true
}
});
Expand Down Expand Up @@ -147,7 +147,7 @@ public async Task When_export_types_is_false_then_dont_add_export_before_classes
GenerateClientInterfaces = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m,
TypeScriptVersion = 4.3m,
ExportTypes = false
}
});
Expand Down Expand Up @@ -176,7 +176,7 @@ public async Task When_generic_request()
GenerateDtoTypes = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.7m,
TypeScriptVersion = 4.3m,
ExportTypes = false
}
});
Expand Down Expand Up @@ -204,7 +204,7 @@ public async Task When_consumes_is_url_encoded_then_construct_url_encoded_reques
Template = TypeScriptTemplate.Angular,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m
TypeScriptVersion = 4.3m
}
});
var code = codeGen.GenerateFile();
Expand Down
12 changes: 6 additions & 6 deletions src/NSwag.CodeGeneration.TypeScript.Tests/AxiosTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public async Task When_export_types_is_true_then_add_export_before_classes()
GenerateClientInterfaces = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m,
TypeScriptVersion = 4.3m,
ExportTypes = true
}
});
Expand Down Expand Up @@ -87,7 +87,7 @@ public async Task When_export_types_is_false_then_dont_add_export_before_classes
GenerateClientInterfaces = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m,
TypeScriptVersion = 4.3m,
ExportTypes = false
}
});
Expand Down Expand Up @@ -117,7 +117,7 @@ public async Task When_consumes_is_url_encoded_then_construct_url_encoded_reques
Template = TypeScriptTemplate.Axios,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m
TypeScriptVersion = 4.3m
}
});
var code = codeGen.GenerateFile();
Expand Down Expand Up @@ -147,7 +147,7 @@ public async Task Add_cancel_token_to_every_call()
UseAbortSignal = false,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m
TypeScriptVersion = 4.3m
}
});
var code = codeGen.GenerateFile();
Expand Down Expand Up @@ -180,7 +180,7 @@ public async Task When_abort_signal()
UseAbortSignal = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m
TypeScriptVersion = 4.3m
}
});
var code = codeGen.GenerateFile();
Expand Down Expand Up @@ -214,7 +214,7 @@ public async Task When_abort_signal_and_generate_client_interfaces_contains_sign
GenerateClientInterfaces = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m
TypeScriptVersion = 4.3m
}
});
var code = codeGen.GenerateFile();
Expand Down
16 changes: 8 additions & 8 deletions src/NSwag.CodeGeneration.TypeScript.Tests/FetchTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ public async Task When_export_types_is_true_then_add_export_before_classes()
GenerateClientInterfaces = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m,
TypeScriptVersion = 4.3m,
ExportTypes = true
}
});
Expand Down Expand Up @@ -90,7 +90,7 @@ public async Task When_export_types_is_false_then_dont_add_export_before_classes
GenerateClientInterfaces = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m,
TypeScriptVersion = 4.3m,
ExportTypes = false
}
});
Expand Down Expand Up @@ -122,7 +122,7 @@ public async Task When_consumes_is_url_encoded_then_construct_url_encoded_reques
Template = TypeScriptTemplate.Fetch,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m
TypeScriptVersion = 4.3m
}
});
var code = codeGen.GenerateFile();
Expand Down Expand Up @@ -152,7 +152,7 @@ public async Task When_abort_signal()
UseAbortSignal = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.7m
TypeScriptVersion = 4.3m
}
});
var code = codeGen.GenerateFile();
Expand Down Expand Up @@ -181,7 +181,7 @@ public async Task When_no_abort_signal()
Template = TypeScriptTemplate.Fetch,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m
TypeScriptVersion = 4.3m
}
});
var code = codeGen.GenerateFile();
Expand Down Expand Up @@ -212,7 +212,7 @@ public async Task When_abort_signal_and_generate_client_interfaces_interface_con
GenerateClientInterfaces = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.7m
TypeScriptVersion = 4.3m
}
});
var code = codeGen.GenerateFile();
Expand Down Expand Up @@ -240,7 +240,7 @@ public async Task When_includeHttpContext()
IncludeHttpContext = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.7m
TypeScriptVersion = 4.3m
}
});
var code = codeGen.GenerateFile();
Expand Down Expand Up @@ -271,7 +271,7 @@ public async Task When_no_includeHttpContext()
Template = TypeScriptTemplate.Angular,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.7m
TypeScriptVersion = 4.3m
}
});
var code = codeGen.GenerateFile();
Expand Down
6 changes: 3 additions & 3 deletions src/NSwag.CodeGeneration.TypeScript.Tests/JQueryCallbacksTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public async Task When_export_types_is_true_then_add_export_before_classes()
GenerateClientInterfaces = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m,
TypeScriptVersion = 4.3m,
ExportTypes = true
}
});
Expand Down Expand Up @@ -81,7 +81,7 @@ public async Task When_export_types_is_false_then_dont_add_export_before_classes
GenerateClientInterfaces = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m,
TypeScriptVersion = 4.3m,
ExportTypes = false
}
});
Expand Down Expand Up @@ -111,7 +111,7 @@ public async Task When_consumes_is_url_encoded_then_construct_url_encoded_reques
Template = TypeScriptTemplate.JQueryCallbacks,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m
TypeScriptVersion = 4.3m
}
});
var code = codeGen.GenerateFile();
Expand Down
6 changes: 3 additions & 3 deletions src/NSwag.CodeGeneration.TypeScript.Tests/JQueryPromisesTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ public async Task When_export_types_is_true_then_add_export_before_classes()
GenerateClientInterfaces = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m,
TypeScriptVersion = 4.3m,
ExportTypes = true
}
});
Expand Down Expand Up @@ -81,7 +81,7 @@ public async Task When_export_types_is_false_then_dont_add_export_before_classes
GenerateClientInterfaces = true,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m,
TypeScriptVersion = 4.3m,
ExportTypes = false
}
});
Expand Down Expand Up @@ -111,7 +111,7 @@ public async Task When_consumes_is_url_encoded_then_construct_url_encoded_reques
Template = TypeScriptTemplate.JQueryPromises,
TypeScriptGeneratorSettings =
{
TypeScriptVersion = 2.0m
TypeScriptVersion = 4.3m
}
});
var code = codeGen.GenerateFile();
Expand Down
2 changes: 1 addition & 1 deletion ...gularJSTests.When_consumes_is_url_encoded_then_construct_url_encoded_request.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ export interface IFoo {
}

export class ApiException extends Error {
message: string;
override message: string;
status: number;
response: string;
headers: { [key: string]: any; };
Expand Down
2 changes: 1 addition & 1 deletion ...ngularJSTests.When_export_types_is_false_then_dont_add_export_before_classes.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ interface IFoo {
}

class ApiException extends Error {
message: string;
override message: string;
status: number;
response: string;
headers: { [key: string]: any; };
Expand Down
2 changes: 1 addition & 1 deletion ...hots/AngularJSTests.When_export_types_is_true_then_add_export_before_classes.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export interface IFoo {
}

export class ApiException extends Error {
message: string;
override message: string;
status: number;
response: string;
headers: { [key: string]: any; };
Expand Down
2 changes: 1 addition & 1 deletion ...AngularTests.When_consumes_is_url_encoded_then_construct_url_encoded_request.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export interface IFoo {
}

export class ApiException extends Error {
message: string;
override message: string;
status: number;
response: string;
headers: { [key: string]: any; };
Expand Down
Loading
Loading