fix(discord): smart auto-thread – content-based name, default off, no duplicate responses#1040
Open
Hypn0sis wants to merge 3 commits intoRightNow-AI:mainfrom
Open
fix(discord): smart auto-thread – content-based name, default off, no duplicate responses#1040Hypn0sis wants to merge 3 commits intoRightNow-AI:mainfrom
Hypn0sis wants to merge 3 commits intoRightNow-AI:mainfrom
Conversation
… default off, no duplicate responses
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Three bugs in the Discord adapter:
auto_threadsetting, becausedefault_auto_thread()returned"true"MESSAGE_UPDATE~100ms afterMESSAGE_CREATE(embed resolution); ifcreate_thread()takes >100ms the dedup set isn't populated yet, so a second free-channel response was dispatchedFix
config.rs: changedefault_auto_thread()from"true"→"false"(opt-in)discord.rs: addthread_name_from_message()– strips<@mention>prefix tokens, truncates to 100 chars (Discord limit); insert message ID into dedup set synchronously onMESSAGE_CREATEbefore async thread creationbridge.rs: initialiseeffective_thread_idfrommessage.thread_idunconditionally; move auto-thread creation after all policy guards; fixapi_send_thread_messageto POST tochannels/{thread_id}/messagesDiff size
3 files, ~350 lines – intentionally no formatting or dependency changes.