Optimize BitmapIter::next#292
Merged
Kerollmops merged 3 commits intoRoaringBitmap:mainfrom Oct 18, 2024
Merged
Conversation
20a43fa to
0939502
Compare
the datasets.rs file is only used as a module in the lib benchmarks
0939502 to
b39a3c1
Compare
Kerollmops
approved these changes
Oct 18, 2024
Member
Kerollmops
left a comment
There was a problem hiding this comment.
Nice work on that 👌 Looks good to me, merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, some minor cleanup to the benchmarking.
On my m1 mac, this seems pretty much faster across the board: