Improve the Extend::extend implementation for performances#306
Merged
Kerollmops merged 5 commits intomainfrom Jan 7, 2025
Merged
Improve the Extend::extend implementation for performances#306Kerollmops merged 5 commits intomainfrom
Extend::extend implementation for performances#306Kerollmops merged 5 commits intomainfrom
Conversation
Kerollmops
changed the title
RoaringBitmap::insert_many method
irevoire
suggested changes
Jan 7, 2025
Contributor
irevoire
left a comment
irevoire
left a comment
There was a problem hiding this comment.
The code seems right to me. It could execute way quickly if the iterator was sorted, but I guess that can wait until we need it 😅
My only concerns is that, from what I understand, this function is exactly matching the API of the Extend trait.
Shouldn't we implement that trait instead of making our own function?
Kerollmops
changed the title
RoaringBitmap::insert_many methodExtend::extend implementation for performances
Member
Author
|
You are absolutely right that the Thank you 🙏 |
Merged
Kerollmops
force-pushed
the
insert-many
branch
from
fb164b9 to
4dfd47b
Compare
irevoire
suggested changes
Jan 7, 2025
Contributor
irevoire
left a comment
irevoire
left a comment
There was a problem hiding this comment.
One last smol change and we can merge!
Kerollmops
force-pushed
the
insert-many
branch
from
4dfd47b to
d5dca9a
Compare
meili-bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Jan 13, 2025
5221: Merge bitmaps by using `Extend::extend` r=Kerollmops a=Kerollmops This PR tries to speed up the merging of bitmaps by using [the new `Extend::extend` implementation](RoaringBitmap/roaring-rs#306). Co-authored-by: Clément Renault <clement@meilisearch.com>
meili-bors bot
added a commit
to meilisearch/meilisearch
that referenced
this pull request
Jan 13, 2025
5221: Merge bitmaps by using `Extend::extend` r=Kerollmops a=Kerollmops This PR tries to speed up the merging of bitmaps by using [the new `Extend::extend` implementation](RoaringBitmap/roaring-rs#306). Co-authored-by: Clément Renault <clement@meilisearch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #301.