Add a function for internal validation, and use it in the fuzzer#328
Add a function for internal validation, and use it in the fuzzer#328Kerollmops merged 3 commits intoRoaringBitmap:mainfrom
Conversation
|
Yep, probably found the same issue: |
|
Build is failing because a dependency updated that doesn't support 1.71.1. If we're going to pin to support an older rust version, we probably need to commit a Cargo.lock for that. |
There was a problem hiding this comment.
Thank you for your PR again @Dr-Emann 🙏
I looked at the COBS crate, and it seems they use v1.73~1.74 std features. I'll bump the MSRV to v.1.80.1 (August 2024). I'll let you rebase once I'm done.
EDIT: PR merged with the MSRV bump. Can you rebase on main, please?
| } | ||
| let mut last_end: Option<u16> = None; | ||
| for run in &self.0 { | ||
| if run.start > run.end { |
There was a problem hiding this comment.
Should we check for equality too, as the Interval is an inclusive range?
There was a problem hiding this comment.
Equality should be valid (because it's an inclusive range). You can have {start:0, end:0} to have a single item in the interval.
6cb5cd5 to
164433f
Compare
|
Thanks again for your work 😇 |
Fixes #197
Also adds a simd mode for the fuzzer in the hopes that it could find something like #327