Run containers part 2

[Kerollmops]

I started working on the run containers implementation, my starting point is #56 by @josephglanville.

I fixed some bugs but I'm sure I introduced new ones with the operations on runs, I need to add a lot of new tests for runs.

[josephglanville]

Awesome! I don't have much time to help atm but will review and comment where I can. :)

[josephglanville]

Doh. Good catch.

[josephglanville]

I'm going to start picking this back up @Kerollmops. I noticed the remove_range implementation is most likely not working yet which is preventing the new tests I have added from passing so I will focus on fixing that up and adding the remaining run container store operations. I will open a PR against your branch once I have some progress to show.

[Kerollmops]

Thanks a lot @josephglanville, indeed it seems like I didn't take enough time to make this method work. I hope you fix it, and wait for your PR, thank you 😄

[saik0]

@josephglanville I was taking a look through history in #12

I think storing start, end will result in slightly nicer code vs storing start, run_length.
Serialisation will of course follow the format specification

I haven't made an opportunity to look through the code for this PR yet. Is that what were doing?

My concern is if we deviate we wont be able to use the same "frozen" format for lazy containers

[gcxfd]

when use insert_range in a empty RoaringBitmap , maybe can use RunContainer ?

[josephglanville]

@saik0 yeah that is a valid concern and not something I had thought of at the time but think it makes sense as to make it easier to support mmaped bitmaps without needing separate code for them. I don't think the code is too hard to modify to use start + len instead just have to adjust when searching for intervals etc.

If you want to work on this go ahead, my progress has been slow because I am (as usual) occupied with other things sadly.

[tgruben]

I'm unclear what's needed to finish this, is there anything I can do to help?