BUG: Rollback Prandtl-Glauert corrections for Tail and Nose.#685
Merged
phmbressan merged 2 commits intomasterfrom Sep 11, 2024
Merged
BUG: Rollback Prandtl-Glauert corrections for Tail and Nose.#685phmbressan merged 2 commits intomasterfrom
phmbressan merged 2 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #685 +/- ##
=======================================
Coverage 75.74% 75.74%
=======================================
Files 81 81
Lines 9821 9821
=======================================
Hits 7439 7439
Misses 2382 2382 ☔ View full report in Codecov by Sentry. |
Gui-FernandesBR
approved these changes
Sep 9, 2024
Member
|
For the future... We should allow users to decide if they want their models to follow one assumption or another. |
MateusStano
approved these changes
Sep 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Checklist
black rocketpy/ tests/) has passed locallypytest tests -m slow --runslow) have passed locallyCHANGELOG.mdhas been updated (if relevant)Current behavior
Prandtl-Glauert corrections applied to Tail and Nose produced some unexpected behaviors.
New behavior
This PR rollback the Tail and Nose aerodynamic to the earlier state.
Breaking change