Skip to content

ENH: Rail buttons added to nbbuilder. Other small changes made.#26

Merged
Gui-FernandesBR merged 3 commits intomasterfrom
enh/add_rail_buttons
Jun 15, 2024
Merged

ENH: Rail buttons added to nbbuilder. Other small changes made.#26
Gui-FernandesBR merged 3 commits intomasterfrom
enh/add_rail_buttons

Conversation

@juliomachad0
Copy link
Copy Markdown
Member

Rail buttons added to NotebookBuilder class and some changes made in the compare_results method.

@juliomachad0 juliomachad0 added the enhancement New feature or request label Jun 15, 2024
@juliomachad0 juliomachad0 self-assigned this Jun 15, 2024
juliomachad0 and others added 3 commits June 15, 2024 19:54
This commit adds a warning message to the `NotebookBuilder` class in `nb_builder.py` to handle cases where no rail buttons or fins are added to the rocket. The warning message is displayed in the notebook and logged to provide feedback to the user.

The commit message follows the established convention of using a prefix to indicate the type of change (`chore` for a chore or maintenance task) and provides a clear and concise description of the purpose of the code changes.
Copy link
Copy Markdown
Member

@Gui-FernandesBR Gui-FernandesBR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gui-FernandesBR Gui-FernandesBR merged commit 02b02ee into master Jun 15, 2024
@Gui-FernandesBR Gui-FernandesBR deleted the enh/add_rail_buttons branch June 15, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants