Skip to content

fix: code analysis package consumption #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RLittlesII merged 3 commits into from
Sep 22, 2025
Merged

fix: code analysis package consumption #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ea4b09
fix: code analysis package consumption
RLittlesII Sep 22, 2025
5410a01
fix dependencies
RLittlesII Sep 22, 2025
cab5777
seems to package correctly now
RLittlesII Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/Analyzers/Analyzers.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
Expand All @@ -12,16 +12,14 @@
<Description>Common analyzers for MVVM, MVU, Rx, and Airframe coding standards.</Description>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.Common" PrivateAssets="all"/>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" PrivateAssets="all"/>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" PrivateAssets="all"/>
</ItemGroup>
<ItemGroup>
<None Include="..\..\AnalyzerReleases.Shipped.md" Pack="true" PackagePath="\"/>
</ItemGroup>
<ItemGroup>
<InternalsVisibleTo Include="$(AssemblyName).Tests"/>
<InternalsVisibleTo Include="Rocket.Surgery.Airframe.CodeFixes"/>
<InternalsVisibleTo Include="Rocket.Surgery.Airframe.CodeFixes.Tests"/>
</ItemGroup>
<ItemGroup>
<None Include="$(OutputPath)\$(AssemblyName).dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false"/>
</ItemGroup>
</Project>
40 changes: 21 additions & 19 deletions src/CodeAnalysis/CodeAnalysis.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,29 +1,31 @@
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<IsPackable>false</IsPackable>
<Description>Analyzers and Codfixes</Description>
<DevelopmentDependency>true</DevelopmentDependency>
<IncludeBuildOutput>false</IncludeBuildOutput>
<IsPackable>true</IsPackable>
<PackageId>Rocket.Surgery.Airframe.CodeAnalysis</PackageId>
<PackageType>Analyzer</PackageType>
<IncludeBuildOutput>false</IncludeBuildOutput>
<DevelopmentDependency>true</DevelopmentDependency>
</PropertyGroup>
<ItemGroup>
<None Include="..\Analyzers\bin\$(Configuration)\netstandard2.0\Analyzers.csproj"
Pack="true"
PackagePath="analyzers\dotnet\cs\Rocket.Surgery.Airframe.Analyzers.dll"
Visible="false" />
<None Include="..\CodeFixes\bin\$(Configuration)\netstandard2.0\CodeFixes.csproj"
Pack="true"
PackagePath="analyzers\dotnet\cs\Rocket.Surgery.Airframe.CodeFixes.dll"
Visible="false" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Analyzers\Analyzers.csproj"/>
<ProjectReference Include="..\CodeFixes\CodeFixes.csproj"/>
<ProjectReference Include="..\Analyzers\Analyzers.csproj">
<ReferenceOutputAssembly>true</ReferenceOutputAssembly>
<OutputItemType>Analyzer</OutputItemType>
</ProjectReference>
<ProjectReference Include="..\CodeFixes\CodeFixes.csproj">
<ReferenceOutputAssembly>true</ReferenceOutputAssembly>
<OutputItemType>Analyzer</OutputItemType>
</ProjectReference>
</ItemGroup>
<ItemGroup>
<Analyzer Include="..\Analyzers\bin\$(Configuration)\netstandard2.0\Rocket.Surgery.Airframe.Analyzers.dll" />
<Analyzer Include="..\CodeFixes\bin\$(Configuration)\netstandard2.0\Rocket.Surgery.Airframe.CodeFixes.dll" />
<None Include="..\Analyzers\bin\$(Configuration)\netstandard2.0\Rocket.Surgery.Airframe.Analyzers.dll"
Pack="true"
PackagePath="analyzers\dotnet\cs\Rocket.Surgery.Airframe.Analyzers.dll"
Visible="false" />
<None Include="..\CodeFixes\bin\$(Configuration)\netstandard2.0\Rocket.Surgery.Airframe.CodeFixes.dll"
Pack="true"
PackagePath="analyzers\dotnet\cs\Rocket.Surgery.Airframe.CodeFixes.dll"
Visible="false" />
</ItemGroup>
</Project>
</Project>
6 changes: 1 addition & 5 deletions src/CodeFixes/CodeFixes.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,12 @@
<ImplicitUsings>enable</ImplicitUsings>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.CodeAnalysis.Common" PrivateAssets="all"/>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" PrivateAssets="all"/>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" PrivateAssets="all"/>
</ItemGroup>
<ItemGroup>
<InternalsVisibleTo Include="$(AssemblyName).Tests"/>
</ItemGroup>
<ItemGroup>
<None Include="$(OutputPath)\$(AssemblyName).dll" Pack="true" PackagePath="analyzers/dotnet/cs" Visible="false"/>
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\Analyzers\Analyzers.csproj" />
</ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/directory.build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<Project>
<Import Project="$([MSBuild]::GetPathOfFileAbove('directory.build.targets', '$(MSBuildThisFileDirectory)../'))" />
<Import Project="$([MSBuild]::GetPathOfFileAbove('directory.build.targets', '$(MSBuildThisFileDirectory)../'))"/>
</Project>
Loading