Merged
Conversation
…able releases Co-authored-by: Romanitho <96626929+Romanitho@users.noreply.github.com>
…builds Co-authored-by: Romanitho <96626929+Romanitho@users.noreply.github.com>
…-process Fix nightly builds to use chronological tag sorting instead of version sorting
Refactored the prerequisite check for Microsoft Visual C++ 2015-2022 Redistributable to use architecture-specific registry paths and version checks. The script now determines the OS architecture dynamically, checks for the required minimum version, and only downloads and installs the redistributable if necessary. Improved logging and error handling for better clarity.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Improve VC++ Redistributable installation logic
Bumps [stefanzweifel/git-auto-commit-action](https://github.com/stefanzweifel/git-auto-commit-action) from 7.0.0 to 7.1.0. - [Release notes](https://github.com/stefanzweifel/git-auto-commit-action/releases) - [Changelog](https://github.com/stefanzweifel/git-auto-commit-action/blob/master/CHANGELOG.md) - [Commits](stefanzweifel/git-auto-commit-action@28e16e8...04702ed) --- updated-dependencies: - dependency-name: stefanzweifel/git-auto-commit-action dependency-version: 7.1.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [oxsecurity/megalinter](https://github.com/oxsecurity/megalinter) from 9.2.0 to 9.3.0. - [Release notes](https://github.com/oxsecurity/megalinter/releases) - [Changelog](https://github.com/oxsecurity/megalinter/blob/main/CHANGELOG.md) - [Commits](oxsecurity/megalinter@55a59b2...42bb470) --- updated-dependencies: - dependency-name: oxsecurity/megalinter dependency-version: 9.3.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
…elop/oxsecurity/megalinter-9.3.0 Bump oxsecurity/megalinter from 9.2.0 to 9.3.0
…elop/stefanzweifel/git-auto-commit-action-7.1.0 Bump stefanzweifel/git-auto-commit-action from 7.0.0 to 7.1.0
ServiceUI.exe is now added directly to the repository, eliminating the need to download and install Microsoft Deployment Toolkit (MDT), which has been decommissioned by Microsoft. The build workflow is updated to reflect this change, simplifying the build process and reducing external dependencies.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Include ServiceUI.exe in source and remove MDT dependency
Updates Start-Process call to remove unsupported WindowStyle argument in ISE workaround.
Fix process arguments in Winget-Install.ps1
Romanitho
had a problem deploying
to
megalinter
GitHub Actions
Failure
Contributor
✅
|
| Descriptor | Linter | Files | Fixed | Errors | Warnings | Elapsed time |
|---|---|---|---|---|---|---|
| ✅ COPYPASTE | jscpd | yes | no | no | 2.85s | |
| ✅ POWERSHELL | powershell | 2 | 0 | 0 | 5.0s | |
| ✅ POWERSHELL | powershell_formatter | 2 | 0 | 0 | 2.61s | |
| checkov | yes | 3 | no | 13.81s | ||
| devskim | yes | 1 | 8 | 1.45s | ||
| ✅ REPOSITORY | dustilock | yes | no | no | 0.01s | |
| ✅ REPOSITORY | gitleaks | yes | no | no | 0.48s | |
| ✅ REPOSITORY | git_diff | yes | no | no | 0.01s | |
| ✅ REPOSITORY | grype | yes | no | no | 31.84s | |
| ✅ REPOSITORY | kics | yes | no | no | 1.03s | |
| ✅ REPOSITORY | kingfisher | yes | no | no | 3.78s | |
| ✅ REPOSITORY | secretlint | yes | no | no | 0.48s | |
| ✅ REPOSITORY | syft | yes | no | no | 1.17s | |
| ✅ REPOSITORY | trivy | yes | no | no | 5.51s | |
| ✅ REPOSITORY | trivy-sbom | yes | no | no | 0.12s | |
| ✅ REPOSITORY | trufflehog | yes | no | no | 2.3s | |
| cspell | 3 | 7 | 0 | 4.03s |
Detailed Issues
⚠️ REPOSITORY / checkov - 3 errors
Linter output file not found
⚠️ SPELL / cspell - 7 errors
Linter output file not found
⚠️ REPOSITORY / devskim - 1 error
Linter output file not found
See detailed reports in MegaLinter artifacts
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff
Contributor
There was a problem hiding this comment.
Pull request overview
Pre-release PR for v2.10.0 that updates prerequisites handling and adjusts CI/release workflows to support the release process (including bundling ServiceUI.exe rather than extracting it from MDT).
Changes:
- Update WinGet prerequisite installation logic (VC++ runtime detection + arch-aware dependency URLs).
- Bundle
ServiceUI.exein the repository and remove Microsoft Deployment Toolkit (MDT) installation from release/nightly workflows. - Update GitHub Actions (tag selection logic + action version bumps / formatting cleanups).
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
Sources/Winget-AutoUpdate/functions/Install-Prerequisites.ps1 |
Refactors VC++ redistributable detection/installation and makes VCLibs/UI.Xaml downloads arch-aware. |
Sources/Winget-AutoUpdate/Winget-Install.ps1 |
Minor formatting cleanup and removes an incompatible Start-Process option in the ISE workaround. |
Sources/Winget-AutoUpdate/ServiceUI.exe |
Adds ServiceUI.exe to source so WAU no longer needs MDT during CI builds. |
.github/workflows/GitFlow_Nightly-builds.yml |
Uses date-sorted tags and removes MDT install/copy steps (expects ServiceUI.exe in repo). |
.github/workflows/GitFlow_Make-Release-and-Sync-to-Dev.yml |
Removes MDT install/copy steps (expects ServiceUI.exe in repo). |
.github/workflows/GA_Mega-linter.yml |
Bumps pinned action revisions (MegaLinter + git-auto-commit-action). |
Romanitho
had a problem deploying
to
megalinter
GitHub Actions
Failure
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 2.10.0
This PR is automatically created to perform the final tests and validations before the release is created.