Add query generator#9
Add query generator#9yamalight wants to merge 10 commits intoRubenVerborgh:masterfrom yamalight:master
Conversation
|
Thanks! Let me go through the commits, consolidate them, add a README, and I'll merge. |
|
BTW By what name may I credit you in the README? 😉 |
|
@RubenVerborgh Ah, totally forgot about that part 😄 |
|
Could you please fix these issues?
I'll then make some further edits before merging. |
|
Okay, will rebase to make it look nice. |
…from passing)
|
okay, all fixed, rebased and pushed. |
|
Thanks, will review in-depth and then merge. Excellent work! |
|
@RubenVerborgh any updates? 😄 |
|
Still traveling; on to-do list. |
|
okay, cool. please, ping me once it's merged :) |
|
FYI I'm still working on this, but some things are taking a bit more time than expected. Some code, while working as intended, does not accurately reflect functionality. For instance: var varSymbols = ['?', '_:', '"', '*']; // symbols presence of which means that string is SPARQL variableSo sorry for the delay, but I'm taking quality control very seriously 😉 |
|
sounds good! 👍 |
7d22908 to
ef0c504
Compare
|
Thanks for implementing this. Merged in master! |
|
had a quick look - seems to be good. |
|
Thx! Will document interface and release a version one of these days. |
|
cool! 😸 |
|
Released as v1.1.0. |
|
awesome! now to update the deps.. :D |
Adds query generator for #4