rust: avoid ICE on attributed struct base parsing#4514
Open
hriztam wants to merge 1 commit intoRust-GCC:masterfrom
Open
rust: avoid ICE on attributed struct base parsing#4514hriztam wants to merge 1 commit intoRust-GCC:masterfrom
hriztam wants to merge 1 commit intoRust-GCC:masterfrom
Conversation
P-E-P
approved these changes
May 6, 2026
| @@ -0,0 +1,12 @@ | |||
| // { dg-options "-frust-incomplete-and-experimental-compiler-do-not-use" } | |||
Member
There was a problem hiding this comment.
This is not required, it is already injected thanks to compile.exp
gcc/rust/ChangeLog: * parse/rust-parse-error.h (StructExprField): Add STRUCT_BASE_ATTRIBUTES. * parse/rust-parse-impl-expr.hxx (Parser<ManagedTokenSource>::parse_struct_expr_field): Reject attributes before struct-base `..`. (Parser<ManagedTokenSource>::parse_struct_expr_struct_partial): Handle struct-base parse results without dereferencing an errored expected. gcc/testsuite/ChangeLog: * rust/compile/issue-4476.rs: New test. Signed-off-by: Hritam Shrivastava <hritamstark05@gmail.com>
hriztam
force-pushed
the
fix/internal_compiler_fix
branch
from
131e341 to
8c466b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #4476
rust: avoid ICE on attributed struct base parsing
Parsing a struct expression like
Foo { #[cfg(feature = -1)] .. }could ICE because
parse_struct_expr_struct_partial()unconditionallycalled
value()on an erroredStructExprFieldresult afterparse_struct_expr_field()had already identified..as the structbase.
Handle that case explicitly, emit a normal parser diagnostic when
attributes are attached to the struct-base
.., and add a regressiontest for the reduced reproducer.
Signed-off-by: Hritam Shrivastava hritamstark05@gmail.com