Skip to content

Add #[ignore] to bingcd tests #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Jun 19, 2025
Merged

Add #[ignore] to bingcd tests #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/crypto-bigint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ jobs:
- run: cargo test --target ${{ matrix.target }} --no-default-features ${{ matrix.args }}
- run: cargo test --target ${{ matrix.target }} ${{ matrix.args }}
- run: cargo test --target ${{ matrix.target }} --all-features ${{ matrix.args }}
- run: cargo test --target ${{ matrix.target }} --all-features ${{ matrix.args }} -- --ignored # slow bingcd tests

# Test using `cargo careful`
test-careful:
Expand Down
1 change: 1 addition & 0 deletions src/uint/bingcd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ mod tests {
}

#[test]
#[ignore] // TODO(tarcieri): improve performance

@tarcieri tarcieri Jun 19, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erik-3milabs I can list you on these if you prefer (or we can open a tracking issue and put the issue number)

@erik-3milabs erik-3milabs Jun 20, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm already working on this in #846 :)

fn test_bingcd() {
let mut rng = ChaCha8Rng::from_seed(*b"01234567890123456789012345678901");
bingcd_tests::<{ U256::LIMBS }>(&mut rng);
Expand Down
2 changes: 2 additions & 0 deletions src/uint/bingcd/gcd.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ mod tests {
}

#[test]
#[ignore] // TODO(tarcieri): improve performance
fn test_classic_bingcd() {
let mut rng = ChaCha8Rng::from_seed(*b"01234567890123456789012345678901");
classic_bingcd_tests::<{ U64::LIMBS }>(&mut rng);
Expand Down Expand Up @@ -243,6 +244,7 @@ mod tests {
}

#[test]
#[ignore] // TODO(tarcieri): improve performance
fn test_optimized_bingcd() {
let mut rng = ChaCha8Rng::from_seed(*b"01234567890123456789012345678901");

Expand Down