Clean up build system in preparation of SFML 2.6.0 and 3.0.0 releases#172
Merged
eXpl0it3r merged 5 commits intoSFML:masterfrom Feb 20, 2023
ChrisThrasher:cmake_improvements
Merged
Clean up build system in preparation of SFML 2.6.0 and 3.0.0 releases#172eXpl0it3r merged 5 commits intoSFML:masterfrom ChrisThrasher:cmake_improvements
eXpl0it3r merged 5 commits intoSFML:masterfrom
ChrisThrasher:cmake_improvements
Conversation
Member
Author
|
Is this something we still want? |
eXpl0it3r
requested changes
Feb 20, 2023
Member
eXpl0it3r
left a comment
eXpl0it3r
left a comment
There was a problem hiding this comment.
I thought, since this had 2.6.0 and 3.0.0 in the title, that it changed stuff towards those version 😄
eXpl0it3r
requested changes
Feb 20, 2023
eXpl0it3r
approved these changes
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a few changes that bring the CSFML build scripts more in line with what the SFML 2.6.x build scripts look like as well as a tweak to CI to update a deprecated CI environment we were still using. The only drastic change I may recommend we make is enabling compiler warnings as we did recently in SFML 2 and 3. I'm not sure how valuable that would be, but at least adding a few basic warnings would be a good idea.