Merged
Conversation
eXpl0it3r
reviewed
Jul 7, 2023
ChrisThrasher
force-pushed
the
compiler_warnings
branch
2 times, most recently
from
5bdfdb4 to
b8d6c9c
Compare
Some minor tweaks were made to remove Android-specific workarounds that CSFML doesn't need and removing a few warnings that are not feasible to fix at the moment.
ChrisThrasher
force-pushed
the
compiler_warnings
branch
from
b8d6c9c to
6b2edac
Compare
kimci86
approved these changes
Jul 8, 2023
eXpl0it3r
approved these changes
Jul 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This caught a few bugs with incorrect conversions, string truncations, and incorrect transform comparisons.