Merged
Conversation
Member
|
The reason we haven't supported static linking with CSFML is, that it stops being a C-library when you link it statically, as the C linker wouldn't know what to do with these C++ symbols. Not exactly sure if allowing to link CSFML statically as C++ library is really useful in any way, as you then could just directly use SFML to begin with... 🤔 |
Member
Author
|
If static builds aren't reasonable then let's hardcode the use of shared libraries into CSFML itself. We can use the For now I'll remove the static lib stuff from this PR so it's only about new CI jobs. |
eXpl0it3r
approved these changes
Jul 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR started off adding new compilers. Eventually I added static builds (instead of only shared builds) and quickly discovered there were some issues with incorrect
dllimport/dllexportstatements. I found out that CSFML lacked the sameCSFML_STATICdefinition that SFML has for supported static library builds so I ported that over from SFML in an identical fashion and now the new and improved CI pipeline is happy.EDIT: I removed the static library bits so this PR is now only about adding CI jobs