Conversation
eXpl0it3r
requested changes
Feb 17, 2024
Member
eXpl0it3r
left a comment
eXpl0it3r
left a comment
There was a problem hiding this comment.
Just some bike shedding.
If the var == true aren't needed anymore, I'd want to see them removed.
Other than that, I think it can be merged. I've already created a 2.6.x branch 🙂
ChrisThrasher
force-pushed
the
v3
branch
3 times, most recently
from
69ab8ac to
f87b1ff
Compare
Member
Author
|
Good feedback. I think I've addressed all your comments. |
kimci86
reviewed
Feb 19, 2024
ChrisThrasher
force-pushed
the
v3
branch
4 times, most recently
from
19c56f7 to
925d13b
Compare
This required silencing C5105 which emits warnings about system headers which we can't change. https://learn.microsoft.com/en-us/cpp/error-messages/compiler-warnings/c5105?view=msvc-170
This also gets rid of exec_program which has been deprecated in CMake.
Member
Author
|
I found some more modernizations/simplifications to make and am done with that effort now. This PR is ready for review again. Better merge it soon before I find more things to change :) |
kimci86
approved these changes
Feb 19, 2024
Contributor
kimci86
left a comment
kimci86
left a comment
There was a problem hiding this comment.
Nothing else to complain about when skimming through 👍
Marioalexsan
approved these changes
Feb 19, 2024
eXpl0it3r
approved these changes
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With 2.6.0 now released we're ready to start working towards v3! With SFML 3 not even finalized it will take a while to get there but luckily there are some easy places to start. This branch includes a mixture of breakages that could not happen in the v2 release series and modernizations that require newer language standards than what v2 uses.
To match SFML this PR upgrades us to CMake 3.22 and C++17. I also upgraded the C requirement to C11. I'm most happy with how requiring C99 now gives us access to basic quality of life features like fixed-width integers and boolean literals. CSFML is being brought into the 21st century 😊
I'm no expert in C standards but from what I've heard C17 is basically identical to C11. It probably wouldn't hurt to eventually raise the C requirement to C17 but for now I picked C11 to ensure we have access to newer features that may prove useful.