Merged
Conversation
Member
Author
|
Failures are due to me first targeting master 😅 |
Comment on lines
+4
to
+5
| push: | ||
| branches: |
Member
There was a problem hiding this comment.
Nit: We use 2 space indentations for GitHub Actions YAML code
Comment on lines
+210
to
+214
| cmake -S SFML -B SFML-build -G "Unix Makefiles" \ | ||
| -DCMAKE_C_COMPILER="/usr/bin/clang" \ | ||
| -DCMAKE_CXX_COMPILER="/usr/bin/clang++" \ | ||
| -DCMAKE_C_FLAGS="-stdlib=libc++" \ | ||
| -DCMAKE_CXX_FLAGS="-stdlib=libc++" \ |
Member
There was a problem hiding this comment.
These choices for generator, compiler, and standard library are already the defaults on macOS so we can omit these arguments if we want.
Member
Author
There was a problem hiding this comment.
Hmmm I did get different results when I was playing with SDKs for the standard library and compiler, but I guess it's not needed for the standard case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another step in automating releases. This prepares packages as we've been releasing as pre-built binaries for Windows and macOS. For Linux it's still advised to use official packages or build from source due to glibc and other compatibility issues.
For macOS was unable build for older macOS SDK version as we used to. With Apple not providing any reasonable support in this area and them heavily pushing users to new OS versions, I don't necessarily see this in our responsibility.
In case anyone wants to try. I got stuck on the compiler not finding the
<ostream>header 🤷