Use SFML_ROOT to find SFML installation#286
Merged
ChrisThrasher merged 1 commit intomasterfrom Sep 3, 2024
Merged
Conversation
ChrisThrasher
force-pushed
the
sfml_root
branch
3 times, most recently
from
c717b5d to
69e76ad
Compare
This is line with modern CMake convention where -D<PackageName>_ROOT is used to locate a given package's installation. https://cmake.org/cmake/help/latest/variable/PackageName_ROOT.html#variable:%3CPackageName%3E_ROOT
ChrisThrasher
force-pushed
the
sfml_root
branch
from
69e76ad to
89b6cd3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is line with modern CMake convention where
-D<PackageName>_ROOTis used to locate a given package's installation.https://cmake.org/cmake/help/latest/variable/PackageName_ROOT.html#variable:%3CPackageName%3E_ROOT
SFML already uses this convention. See SFML/SFML@30a986e