Skip to content

Update sRGB API for Texture and RenderTarget #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eXpl0it3r merged 1 commit into from
Jun 3, 2024
Merged

Update sRGB API for Texture and RenderTarget #252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/SFML.Graphics/RenderTarget.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,14 @@ public interface RenderTarget
////////////////////////////////////////////////////////////
Vector2u Size { get; }


////////////////////////////////////////////////////////////
/// <summary>
/// Tell if the render target will use sRGB encoding when drawing on it
/// </summary>
////////////////////////////////////////////////////////////
bool IsSrgb { get; }
Comment thread
eXpl0it3r marked this conversation as resolved.

////////////////////////////////////////////////////////////
/// <summary>
/// Default view of the target
Expand Down
23 changes: 18 additions & 5 deletions src/SFML.Graphics/Texture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,26 +190,39 @@ public Texture(Image image, IntRect area, bool srgb = false) :
/// <exception cref="LoadingFailedException" />
////////////////////////////////////////////////////////////
public Texture(byte[] bytes, bool srgb = false) :
this(bytes, new IntRect(0, 0, 0, 0), srgb)
{
}

////////////////////////////////////////////////////////////
/// <summary>
/// Construct the texture from a file in memory
/// </summary>
/// <param name="bytes">Byte array containing the file contents</param>
/// <param name="area">Area of the image to load</param>
/// <param name="srgb">True to convert the texture source from sRGB, false otherwise</param>
/// <exception cref="LoadingFailedException" />
////////////////////////////////////////////////////////////
public Texture(byte[] bytes, IntRect area, bool srgb = false) :
base(IntPtr.Zero)
{
GCHandle pin = GCHandle.Alloc(bytes, GCHandleType.Pinned);
try
{
IntRect rect = new IntRect(0, 0, 0, 0);

if (srgb)
{
CPointer = sfTexture_createSrgbFromMemory(pin.AddrOfPinnedObject(), Convert.ToUInt64(bytes.Length), ref rect);
CPointer = sfTexture_createSrgbFromMemory(pin.AddrOfPinnedObject(), Convert.ToUInt64(bytes.Length), ref area);
}
else
{
CPointer = sfTexture_createFromMemory(pin.AddrOfPinnedObject(), Convert.ToUInt64(bytes.Length), ref rect);
}
CPointer = sfTexture_createFromMemory(pin.AddrOfPinnedObject(), Convert.ToUInt64(bytes.Length), ref area);
}
}
finally
{
pin.Free();
}

if (CPointer == IntPtr.Zero)
{
throw new LoadingFailedException("texture");
Expand Down