Skip to content

Conversation

@solon
Copy link
Member

@solon solon commented Jun 18, 2019

  • Tweaks the padding to reveal more of the background image on the homepage jumbotron component
  • Beautifies style.scss (following the current convention of using tabs for indentation)

fixes #85

Before

image

After

image

@solon solon requested a review from rileyjshaw June 18, 2019 02:39
position: absolute;
top: 1px;
right: 0;
background: -moz-linear-gradient(left, rgba(255, 255, 255, 0) 0%, rgba(255, 255, 255, 1) 15%, rgba(255, 255, 255, 1) 100%); /* FF3.6+ */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker, but some of these prefixed properties aren't needed anymore. It would be nice to get autoprefixer set up to avoid having to manually write / check this.

@rileyjshaw rileyjshaw merged commit 5083fe4 into SFPC:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add padding on homepage image well for mobile

2 participants