Skip to content

Implement RTL language support in draggable grid#91

Merged
SHISME merged 1 commit intoSHISME:masterfrom
faizanu94:feat/add-rtl-support
Mar 26, 2024
Merged

Implement RTL language support in draggable grid#91
SHISME merged 1 commit intoSHISME:masterfrom
faizanu94:feat/add-rtl-support

Conversation

@faizanu94
Copy link
Contributor

This PR introduces support for Right-to-Left (RTL) languages in the react-native-draggable-grid package, addressing the issues outlined in #90. It ensures that item ordering and drag-and-drop behavior are correctly handled in RTL mode, improving the user experience and accessibility for RTL language apps. The changes include adjustments to item ordering logic and enhancements to drag-and-drop functionality to align with the natural reading and interaction patterns of RTL users

@PPHelios
Copy link

@faizanu94 Thank you for addressing this issue ,but as this fix is not merged yet I tried copying your modifications in draggable-grid.tsx to the same file in my node modules, but it still behaves in the same way, how can i implement it?
Thanks in advance

@SHISME SHISME merged commit 0b0a64a into SHISME:master Mar 26, 2024
@SHISME
Copy link
Owner

SHISME commented Mar 26, 2024

Thanks for the mr, i had published it on 2.2.0 @PPHelios

@PPHelios
Copy link

Thank you for the great library and fast response, but unfortunately as I mentioned earlier this fix is not working for me, as you can see in the attached video the x axis is still reversed in rtl.
Any suggestions?

SVID_20240326_161916_1.mp4

@SHISME
Copy link
Owner

SHISME commented Mar 27, 2024

Thank you for the great library and fast response, but unfortunately as I mentioned earlier this fix is not working for me, as you can see in the attached video the x axis is still reversed in rtl. Any suggestions?

SVID_20240326_161916_1.mp4

ok, i will check it

@faizanu94
Copy link
Contributor Author

Hi @SHISME I've fetched the latest published version of this library (2.2.0 which you recently published) and it doesn't contain the changes implemented in this PR. Can you republish it again?

unpkg: https://unpkg.com/browse/react-native-draggable-grid@2.2.0/built/src/draggable-grid.js

@SHISME
Copy link
Owner

SHISME commented Mar 28, 2024

Hi @SHISME I've fetched the latest published version of this library (2.2.0 which you recently published) and it doesn't contain the changes implemented in this PR. Can you republish it again?

unpkg: https://unpkg.com/browse/react-native-draggable-grid@2.2.0/built/src/draggable-grid.js

Sorry, long time not pulished, i forgot build before publish

you can try with 2.2.1 @PPHelios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants