Fix panic error when downloading podcast with existing ID3v2.2 tags.#739
Merged
SamTV12345 merged 1 commit intoSamTV12345:mainfrom May 12, 2024
Merged
Fix panic error when downloading podcast with existing ID3v2.2 tags.#739SamTV12345 merged 1 commit intoSamTV12345:mainfrom
SamTV12345 merged 1 commit intoSamTV12345:mainfrom
Conversation
Owner
|
Thanks for the pull request and for the fix. Sorry for closing the issue :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request fixes #658 by checking if a podcast episode's tags are ID3v2.2 when downloading. If they are, a completely new tag is generated in the default format (ID3v2.4).
Linked Issues
#658 and #690
Additional context
The panic error was caused by the podcast episodes having ID3v2.2 tags which use three character frames. Since the existing tags are used as a baseline and the tag being written to new downloads is ID3v2.4 which use four character frames, there was a panic error due to the mismatch.
Thank you for your work on this project and the guidance via commit #690 so I could find the right area to explore!