claude-code: add missing settings#5822
Open
bendrucker wants to merge 1 commit into
Open
Conversation
Add theme, preferredNotifChannel, autoCompactEnabled, skipWorkflowUsageWarning, skipAutoPermissionPrompt, inputNeededNotifEnabled, and agentPushNotifEnabled to the Claude Code settings schema with types sourced from the Claude Code v2.1.179 settings schema. theme is modeled as an enum-or-custom: union to match the CLI. Adds positive and negative test coverage.
Contributor
|
Thanks for the PR! This section of the codebase is owned by @domdomegg, @bogini, @sarahdeaton, and @ant-kurt - if they write a comment saying "LGTM" then it will be merged. |
bendrucker
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds seven settings to
claude-code-settings.jsonthat Claude Code accepts but the schema did not model:theme,preferredNotifChannel,autoCompactEnabled,skipWorkflowUsageWarning,skipAutoPermissionPrompt,inputNeededNotifEnabled, andagentPushNotifEnabled.The schema sets
additionalProperties: true, soajvnever rejected these keys.Types, descriptions, and enum values were extracted from the Claude Code v2.1.179 binary's settings schema.
themeis modeled as ananyOfof a built-in enum (auto,dark,light, the daltonized variants, the ansi variants) and a^custom:pattern, matching the CLI'sunion([enum(...), string().startsWith("custom:")]). A bare enum would wrongly reject valid custom themes likecustom:my-theme.Testing
claude-code-settings.jsonis registered with"strict": true, so the coverage tool enforces test completeness. Positive fixtures cover everythemeandpreferredNotifChannelenum value, the^custom:pattern, and a non-default value for each boolean that declares a default. Negative cases (theme: "midnight",preferredNotifChannel: "slack") go in the existing all-invalid_enumfile to keep negative-test isolation cohesive. Verified locally withnode ./cli.js check,node ./cli.js coverage, andprettier --checkscoped to this schema.