Skip to content

Add collaboration WebSocket endpoint#12

Merged
jeandet merged 2 commits intoSciQLop:mainfrom
davidbrochart:collaboration
Mar 14, 2025
Merged

Add collaboration WebSocket endpoint#12
jeandet merged 2 commits intoSciQLop:mainfrom
davidbrochart:collaboration

Conversation

@davidbrochart
Copy link
Contributor

from .get_version import *
from .get_server_status import *
from .routes import router as api_router No newline at end of file
from .routes import router as api_router

Check notice

Code scanning / CodeQL

'import *' may pollute namespace Note

Import pollutes the enclosing namespace, as the imported module
speasy_proxy.api.v1.ws_collaboration
does not define '__all__'.
By default, speasy_proxy users only want the cache feature, let's
make collab endpoint an opt-in feature.

Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@sonarqubecloud
Copy link

@jeandet
Copy link
Member

jeandet commented Mar 14, 2025

@davidbrochart thanks! I've pushed on top of this PR an off by default switch to enable the collab endpoint.

@jeandet jeandet self-requested a review March 14, 2025 14:07
@jeandet jeandet added the enhancement New feature or request label Mar 14, 2025
@jeandet jeandet merged commit 5ef8e3c into SciQLop:main Mar 14, 2025
4 checks passed
@davidbrochart davidbrochart deleted the collaboration branch March 14, 2025 14:11
@jeandet
Copy link
Member

jeandet commented Mar 14, 2025

Just for the record, to enable the collab endpoint, just set:
SPEASY_PROXY_COLLAB_ENDPOINT_ENABLE=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants