Skip to content

Abspath instead of resolve #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
i-oden merged 3 commits into from
Oct 18, 2021
Merged

Abspath instead of resolve #175

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f3a16ed
Abspath instead of resolve
alneberg Oct 18, 2021
f96eb0b
Added warning log messages about broken symlinks and unsupported path…
alneberg Oct 18, 2021
7c619e6
Nice error message for infinite loops as well
alneberg Oct 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion dds_cli/file_handler_local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def __init__(self, user_input, temporary_destination, project):
)

# Get absolute paths for all data
self.data_list = [pathlib.Path(path).resolve() for path in self.data_list]
self.data_list = [pathlib.Path(os.path.abspath(path)) for path in self.data_list]
Comment thread
i-oden marked this conversation as resolved.

# No data -- cannot proceed
if not self.data_list:
Expand Down Expand Up @@ -145,6 +145,15 @@ def __collect_file_info_local(self, all_paths, folder=pathlib.Path(""), task_nam
folder=folder / pathlib.Path(path.name),
)
file_info.update({**content_info})
else:
if path.is_symlink():
LOG.warning(
f"IGNORED: Link: {path} -> {path.resolve()} seems to be broken, will be ignored."
)
else:
LOG.warning(
f"IGNORED: Path of unsupported/unknown type: {path}, will be ignored."
)

return file_info, progress_tasks

Expand Down