Skip to content

artcraft(*): Prepare persistence for pending portable releases - #19232

Draft
Lorie-Capella wants to merge 2 commits into
ScoopInstaller:masterfrom
Lorie-Capella:fix/artcraft-pending-portable-persistence
Draft

Lorie-Capella wants to merge 2 commits into
ScoopInstaller:masterfrom
Lorie-Capella:fix/artcraft-pending-portable-persistence

Conversation

@Lorie-Capella

@Lorie-Capella Lorie-Capella commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

Relates to #19230. Follow-up to merged #19231.

Do not merge yet. As of 2026-11-13, the latest released CADCraft 0.20.1, DeckCraft 0.18.1, GridCraft 0.19.1 and WordCraft 0.18.1 still lack the portable runtime/ZIP-marker prerequisites below. Adding persist alone does not redirect the profile paths they currently use.

Manifest Prepared portable directory Upstream prerequisite
cadcraft CADCraftData CADCraft #2745, open with conflicts
deckcraft DeckCraftData runtime #207, open with conflicts; ZIP marker #1805, draft
gridcraft GridCraftData runtime #2986, open; ZIP marker #3318, draft
wordcraft WordCraftData WordCraft #1823, open with conflicts; #913 was closed without merging

Merge gates:

  • Upstream runtime support and marker packaging are merged and released.
  • Extras selects those supporting releases.
  • Reverify the actual settings paths, marker behavior and first-install/update persistence before marking this PR ready.

The expanded #19230 audit also covers MaterialCraft and TextureCraft, which still need their own runtime implementations; this PR keeps its existing four-manifest scope. AniCraft, SolidCraft and MailCraft are also in the launcher catalog but currently have no Extras manifests.

Current Extras master has been merged into this branch to clear stale manifest conflicts. Relative to that master, the change is still exactly four persist declarations. Versions, URLs, hashes and autoupdate rules are unchanged. No marker is forced into an unsupported executable, and existing AppData is not copied or overwritten. The separate x86/autoupdate problem is tracked in #19335 and PRs #19320/#19340.

Validation:

  • All four refreshed manifests pass Scoop's installed JSON schema.

  • Normal PR CI passes in Windows PowerShell and pwsh; title checks pass.

  • The fresh /verify run passes lint/description/license/current hashes but fails Checkver, Autoupdate and Autoupdate Hash Extraction for all four manifests. CADCraft's update failure was independently reproduced in an isolated manifest copy: the latest x86 ZIP/checksum is absent and its fallback download returns HTTP 404. This is the existing [Bug]: ArtCraft craft apps stopped updating after upstream dropped 32-bit Windows builds #19335 blocker covered by craft(*): Update to latest version, drop removed 32bit builds #19340; refresh against that repair before release-readiness validation.

  • Git whitespace checks pass with the existing CRLF format preserved.

  • Latest-release x64 ZIP directory listings were checked: all four still omit portable.txt.

  • This remains preparatory validation. No application launch or end-to-end portable-update test was performed against a supporting release, because none is released yet.

  • Use conventional PR title.

  • I have read the Contributing Guide.

@coderabbitai

coderabbitai Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Lorie-Capella

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

All changes look good.

Wait for review from human collaborators.

cadcraft

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

deckcraft

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

gridcraft

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

wordcraft

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@z-Fng z-Fng linked an issue Nov 5, 2026 that may be closed by this pull request
@Lorie-Capella

Copy link
Copy Markdown
Contributor Author

/verify

@github-actions

Copy link
Copy Markdown
Contributor

Your changes did not pass all checks.

Please address the issues in the manifest and comment starting with /verify to rerun the checks.

cadcraft

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

deckcraft

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

gridcraft

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

wordcraft

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@Lorie-Capella

Copy link
Copy Markdown
Contributor Author

Refreshed this draft against current Extras master; the diff is still exactly four one-line persist additions. WordCraft's prerequisite now points to #1823.

Normal PowerShell/pwsh CI and title checks pass. The fresh /verify run fails the version/autoupdate checks for all four manifests, while lint, description, license and current hashes pass. I reproduced the underlying CADCraft update blocker in an isolated manifest copy: 0.20.1 is detected, but the removed Windows x86 ZIP has no checksum and its fallback URL returns 404. That separate problem is already tracked in #19335/#19340.

This stays draft until the x86/autoupdate repair is incorporated and the upstream portable implementations/markers are released. Expanded audit: #19230 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ArtCraft portable settings are not persisted across updates

1 participant