Repository navigation
artcraft(*): Prepare persistence for pending portable releases - #19232
Lorie-Capella wants to merge 2 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
/verify |
|
All changes look good. Wait for review from human collaborators. cadcraft
deckcraft
gridcraft
wordcraft
|
|
/verify |
|
Your changes did not pass all checks. Please address the issues in the manifest and comment starting with cadcraft
deckcraft
gridcraft
wordcraft
|
|
Refreshed this draft against current Extras master; the diff is still exactly four one-line Normal PowerShell/pwsh CI and title checks pass. The fresh This stays draft until the x86/autoupdate repair is incorporated and the upstream portable implementations/markers are released. Expanded audit: #19230 (comment) |
Relates to #19230. Follow-up to merged #19231.
Do not merge yet. As of 2026-11-13, the latest released CADCraft 0.20.1, DeckCraft 0.18.1, GridCraft 0.19.1 and WordCraft 0.18.1 still lack the portable runtime/ZIP-marker prerequisites below. Adding
persistalone does not redirect the profile paths they currently use.Merge gates:
The expanded #19230 audit also covers MaterialCraft and TextureCraft, which still need their own runtime implementations; this PR keeps its existing four-manifest scope. AniCraft, SolidCraft and MailCraft are also in the launcher catalog but currently have no Extras manifests.
Current Extras master has been merged into this branch to clear stale manifest conflicts. Relative to that master, the change is still exactly four
persistdeclarations. Versions, URLs, hashes and autoupdate rules are unchanged. No marker is forced into an unsupported executable, and existing AppData is not copied or overwritten. The separate x86/autoupdate problem is tracked in #19335 and PRs #19320/#19340.Validation:
All four refreshed manifests pass Scoop's installed JSON schema.
Normal PR CI passes in Windows PowerShell and pwsh; title checks pass.
The fresh
/verifyrun passes lint/description/license/current hashes but fails Checkver, Autoupdate and Autoupdate Hash Extraction for all four manifests. CADCraft's update failure was independently reproduced in an isolated manifest copy: the latest x86 ZIP/checksum is absent and its fallback download returns HTTP 404. This is the existing [Bug]: ArtCraft craft apps stopped updating after upstream dropped 32-bit Windows builds #19335 blocker covered by craft(*): Update to latest version, drop removed 32bit builds #19340; refresh against that repair before release-readiness validation.Git whitespace checks pass with the existing CRLF format preserved.
Latest-release x64 ZIP directory listings were checked: all four still omit
portable.txt.This remains preparatory validation. No application launch or end-to-end portable-update test was performed against a supporting release, because none is released yet.
Use conventional PR title.
I have read the Contributing Guide.