Skip to content

Added set default value when select 'wait for...' command#678

Merged
tourdedave merged 4 commits intoSeleniumHQ:v3from
sapzape:default-set-wait-for-command
Jul 9, 2019
Merged

Added set default value when select 'wait for...' command#678
tourdedave merged 4 commits intoSeleniumHQ:v3from
sapzape:default-set-wait-for-command

Conversation

@sapzape
Copy link
Copy Markdown

@sapzape sapzape commented May 8, 2019

Set the default value 3000 (30 seconds) when select 'wait for...' command.
image

Related issue #618

Copy link
Copy Markdown
Member

@corevo corevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests as well

@sapzape
Copy link
Copy Markdown
Author

sapzape commented May 15, 2019

I just used two 'wait for' commands as tests to check the value setting.
Is it the correct test code?

@sapzape
Copy link
Copy Markdown
Author

sapzape commented May 16, 2019

PTAL :)

Copy link
Copy Markdown
Member

@corevo corevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tourdedave wanna take a look?

@corevo corevo requested a review from tourdedave July 9, 2019 11:16
@tourdedave tourdedave closed this Jul 9, 2019
@tourdedave tourdedave reopened this Jul 9, 2019
@tourdedave tourdedave merged commit 14a1a36 into SeleniumHQ:v3 Jul 9, 2019
@98gmarquee
Copy link
Copy Markdown

Glad to see this didn't get forgotten. It keeps hanging me up! lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants