[dotnet] [bidi] Decouple ScreenshotOrigin in BrowsingContext module#15488
Merged
nvborisenko merged 1 commit intoSeleniumHQ:trunkfrom Mar 23, 2025
Merged
[dotnet] [bidi] Decouple ScreenshotOrigin in BrowsingContext module#15488nvborisenko merged 1 commit intoSeleniumHQ:trunkfrom
nvborisenko merged 1 commit intoSeleniumHQ:trunkfrom
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨No code suggestions found for the PR. |
RenderMichael
approved these changes
Mar 23, 2025
This was referenced Sep 12, 2025
This was referenced Sep 19, 2025
This was referenced Oct 1, 2025
This was referenced Dec 21, 2025
This was referenced Jan 19, 2026
This was referenced Feb 16, 2026
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Motivation and Context
Contributes to #15407
Types of changes
Checklist
PR Type
Enhancement, Tests
Description
Decoupled
ScreenshotOriginfromCaptureScreenshotOptionsto avoid nested DTO types.Updated
CaptureScreenshotCommandParametersto use the newScreenshotOriginenum.Refactored related test cases to align with the new structure.
Improved code clarity and future extensibility by removing nested types.
Changes walkthrough 📝
CaptureScreenshotCommand.cs
Decoupled `ScreenshotOrigin` from `CaptureScreenshotOptions`dotnet/src/webdriver/BiDi/Modules/BrowsingContext/CaptureScreenshotCommand.cs
CaptureScreenshotOptions.ScreenshotOriginwith astandalone
ScreenshotOriginenum.CaptureScreenshotCommandParametersto use the standaloneScreenshotOrigin.BrowsingContextTest.cs
Updated tests for refactored `ScreenshotOrigin` usagedotnet/test/common/BiDi/BrowsingContext/BrowsingContextTest.cs
ScreenshotOriginenum.CaptureScreenshotCommandParameters.