Repository navigation
LibShell: Stop reading error source text directly from the source file - #27141
Open
educasadei wants to merge 2 commits into
Open
educasadei wants to merge 2 commits into
educasadei wants to merge 2 commits into
Conversation
The function for running a script file already reads it's source data into a buffer, so also set the source text to it.
Use the saved source text instead of trying to read it directly from the source file, as the source file may be a relative path and the script could have changed the current working directory which would make the path invalid.
github-actions
Bot
added
the
👀 pr-needs-review
LucasChollet
approved these changes
Oct 31, 2026
Member
There was a problem hiding this comment.
Seems perfectly reasonable to me! (I will try to get @alimpfard to take a look too, in case re-reading the file was intentional)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The source file could be taken from a relative path which caused problems when the Shell tried to print error messages for scripts that changed the working directory, because that path had become invalid.