Skip to content

Comments

Added default-config API route#389

Merged
nandhinibsn merged 3 commits intomainfrom
nandhini/default-config-api
Jan 25, 2023
Merged

Added default-config API route#389
nandhinibsn merged 3 commits intomainfrom
nandhini/default-config-api

Conversation

@nandhinibsn
Copy link
Contributor

@nandhinibsn nandhinibsn commented Jan 24, 2023

Description:

Added a new API route called "admin/default_config" to fetch the default config details of Azimuth.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@nandhinibsn nandhinibsn requested a review from gabegma January 24, 2023 21:50
@nandhinibsn nandhinibsn self-assigned this Jan 24, 2023
Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! My only thought is that we might want to get the default for other languages? Right now, there are the defaults for the English config only.

with the language-based dynamic default value.
Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job on your first PR in the back end!!

@nandhinibsn
Copy link
Contributor Author

Thank you Gab and Joseph :)

@nandhinibsn nandhinibsn merged commit 377df59 into main Jan 25, 2023
@nandhinibsn nandhinibsn deleted the nandhini/default-config-api branch January 25, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants