fix(player): retry mounting video stats icon until DOM is ready#1212
Open
dcmclarke wants to merge 5 commits intoSevenTV:masterfrom
Open
fix(player): retry mounting video stats icon until DOM is ready#1212dcmclarke wants to merge 5 commits intoSevenTV:masterfrom
dcmclarke wants to merge 5 commits intoSevenTV:masterfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves #979
When the Video Stats setting is enabled, the stats icon wouldn't show up again after a page reload until the setting was manually toggled off and on. Reported issue since December 2023.
Root cause is a timing problem,
remount()was called once on mount, but at that point Twitch's DOM isn't fully ready yet andspan.live-timedoesn't exist. Fix replaces the single call with a retry loop (tryMount) checking for the element every 500ms, up to 10 attempts (5 seconds total). Once the element is found,remount()called successfully.Tested: video stats icon appears automatically on page load without needing to toggle the setting.
Types of changes
Checklist