fix(kick): update username element selector after changing Kick UI#1220
Open
dcmclarke wants to merge 5 commits intoSevenTV:masterfrom
Open
fix(kick): update username element selector after changing Kick UI#1220dcmclarke wants to merge 5 commits intoSevenTV:masterfrom
dcmclarke wants to merge 5 commits intoSevenTV:masterfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Resolves #1219
Kick changed their UI and removed the
titleattribute from username buttons in chat. 7TV's chat observer was usingbutton[title]to find the username element which silently failed after this change so emotes did not render in Kick chat.Fix updates the selector from
button[title]tobutton.font-boldto match Kick's current markup.Tested: 7TV emotes now render correctly in Kick chat with the updated selector.
Note: Workaround userscript posted in the issue by reporter but this fix addresses root cause directly in codebase.
Types of changes
Checklist