Conversation
Sh1Yo
left a comment
There was a problem hiding this comment.
Hi, thanks for the pull request. I also thought that adding a Dockerfile would be a good idea but didn't have time to create it. There's one suggestion tho, I think it's better to grab the latest release from github(https://github.com/sh1yo/x8/releases/latest/download/x86_64-linux-x8.gz) instead of compiling it every time.
|
thanks for your response. actually the whole point of having a dockerfile is to make it possible to run everywhere. by forcing it to download |
|
Thanks for the response. That makes sense, at least when there are not a lot of precompiled binaries available. Still, your Dockerfile needs a fix - the Cargo.lock file isn't within the repository so it will throw an error after a clone. Also, I think it's better to clean temp files with |
|
oop! you're correct, we don't have about calling |
|
It looks like I should add it to prevent possible conflicts 🤔 It will ruin github stats a bit though.. Didn't notice the second docker container. Then it looks good. Again, thanks for the pr. I'll add Cargo.lock and merge it today. |
can be simply used like this:
$ ls input.txt $ docker run -it -v $PWD:/app x8 -u https://4rt.one/level1 -w /app/input.txtor
$ cat input.txt | docker run -i x8 -u https://4rt.one/level1 -w