fix: change test to read string, not buffer #2042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SheetJSDev
approved these changes
Jul 3, 2020
mohammedsahl
approved these changes
Jul 3, 2020
Contributor
mohammedsahl
left a comment
mohammedsahl
left a comment
There was a problem hiding this comment.
LGTM. Has this been an issue for some time or did it just pop up recently? Just curious
Contributor
|
Relatively recently. When we originally made the test for nodejs, Buffer was used. That's not available in browser. @wlawt found that the some of the node tests weren't be run in-browser, and tried reconciling the two test suites in a previous commit. He tried to run the browser tests and found this issue, and the PR addresses the problem (https://app.saucelabs.com/builds/c1670f5dd3384c968095e8ed797c3d57 is the browser test run) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The browser test
CSV > input > should interpret CRLF newlineswas throwing an error for buffer not being defined.A quick fix was to read it as a
stringinstead of abuffer.This also passes the browser tests and the Sauce Labs tests.