fix(bfcl): use message.content when tool_calls is empty (OpenAI-APIs)#1316
Open
pcabriada wants to merge 1 commit intoShishirPatil:mainfrom
Open
fix(bfcl): use message.content when tool_calls is empty (OpenAI-APIs)#1316pcabriada wants to merge 1 commit intoShishirPatil:mainfrom
pcabriada wants to merge 1 commit intoShishirPatil:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_parse_query_response_FCinOpenAICompletionsHandlerused atry/exceptaround iteratingmessage.tool_calls. Whentool_callsisNone, iteration fails and the code correctly falls back tomessage.content. When some OpenAI-compatible servers (e.g. vLLM) returntool_calls: []for text-only assistant turns, the list comprehension succeeds and yieldsmodel_responses == [], socontentis never read. That breaks multi-step FC flows (e.g. agentic / memory traces collapsing to empty steps).Change
tool_callsonce.model_responsesfrommessage.contentandtool_call_idsto[].Motivation / context
tool_calls: nullwhen there are no tool calls; some gateways use an empty list instead.How to test
From
berkeley-function-call-leaderboardafterpip install -e ., with a configured FC model: