fix: respect waitForInteraction when initialScrollIndex is set#2130
Open
naqvitalha wants to merge 2 commits intomainfrom
Open
fix: respect waitForInteraction when initialScrollIndex is set#2130naqvitalha wants to merge 2 commits intomainfrom
naqvitalha wants to merge 2 commits intomainfrom
Conversation
When initialScrollIndex triggers a programmatic scroll, the scroll handler was unconditionally calling recordInteraction(), which set hasInteracted=true and bypassed the waitForInteraction gate in viewability config. This caused onViewableItemsChanged to fire on mount even when waitForInteraction was true. Move the initialScrollCompleted tracking from a local ref to isInitialScrollComplete on RecyclerViewManager, and gate recordInteraction() behind it so programmatic initial scrolls don't count as user interactions. Fixes #1943
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initialScrollIndexis set, the programmatic scroll was callingrecordInteraction(), bypassingwaitForInteraction: truein viewability config and firingonViewableItemsChangedon mountinitialScrollCompletedtracking from a local ref toisInitialScrollCompleteonRecyclerViewManagerrecordInteraction()in the scroll handler behindisInitialScrollCompleteso programmatic initial scrolls don't count as user interactionsTest plan
waitForInteraction + initialScrollIndex, and does fire after real user interactioninitialScrollIndex=2) starts at correct itemFixes #1943