Vite 2.7 compatibility

[jplhomer]

This PR is a test suite against Vite 2.7 betas to ensure Hydrogen is compatible with the latest SSR changes.

Stackblitz: https://stackblitz.com/edit/hydrogen-da5gft?file=package.json

[frandiox]

Looks like the ESM errors are fixed in vitejs/vite#5693
I still get sourcemap warnings, though. But that's a different issue.

[jplhomer]

Seeing E2E tests fail now: https://github.com/Shopify/hydrogen/runs/4226509082?check_suite_focus=true

Seeing this locally when running the dev server:

export {default} from './dist/esnext/entry-server';
^^^^^^

SyntaxError: Unexpected token 'export'
    at Object.compileFunction (node:vm:352:18)
    at wrapSafe (node:internal/modules/cjs/loader:1025:15)
    at Module._compile (node:internal/modules/cjs/loader:1059:27)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1124:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:816:12)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/translators:201:29)
    at ModuleJob.run (node:internal/modules/esm/module_job:183:25)
    at async Loader.import (node:internal/modules/esm/loader:178:24)
    at async importModuleDynamicallyWrapper (node:internal/vm/module:437:15)

Do we need to do something special to denote our exports as ESM?

[frandiox]

@jplhomer The dev project works for me. Can you try with --force, or reinstalling node_modules? 🤔

The issue we have with the e2e for the worker is likely related to this line: https://github.com/vitejs/vite/blob/96664469e49d44f8c628bf0310bdd03d1c4556de/packages/vite/src/node/plugins/ssrRequireHook.ts#L50

That require ends up in our built worker.js. And of course, require doesn't exist in a worker environment.

[frandiox]

After the last next commit, e2e starts passing when using Vite's main branch. That should be released in a few hours as beta.7 .

[frandiox]

@jplhomer all green! 🟢 🎉

[jplhomer]

DOPE. Thanks for all of your work @frandiox (and Vite team, of course).

[frandiox]

@jplhomer 2.7.0 released and looks like it works well :)

Should we merge this?

[jplhomer]

Let's do it! Will merge when CI passes.