-
Notifications
You must be signed in to change notification settings - Fork 386
Open
Description
What is the location of your example repository?
https://github.com/Shopify/hydrogen/tree/main/templates/skeleton
Which package or tool is having this issue?
Hydrogen
What version of that package or tool are you using?
2026.1.0
What version of Remix are you using?
7.12.0
Steps to Reproduce
- Install Urban VPN browser extension (note that this is only one example, there could be more extensions)
- Visit any Hydrogen store (e.g., https://skeleton.hydrogen.shop/)
- Open browser developer console
- Observe
TypeError: Cannot redefine property: Shopifyerror - Notice the app crashes/becomes unusable (The Remix/RR error boundary kicks in)
Expected Behavior
- Framework resilience: Hydrogen apps should not crash regardless of which browser extensions users have installed
- Defensive coding: The logic in ShopifyCustomerPrivacy.tsx:344 should check if
window.Shopifyis already defined and handle both configurable and non-configurable scenarios gracefully - Consistent experience: Hydrogen should provide the same level of stability as Shopify Theme stores when dealing with third-party scripts
- Graceful degradation: If an extension conflicts with Hydrogen's property definitions, the app should continue functioning with appropriate fallback behavior
- User-first approach: End users shouldn't need to disable legitimate browser extensions to use Hydrogen stores
Actual Behavior
App becomes completely unusable with TypeError: Cannot redefine property: Shopify when browser extensions define the property as non-configurable.
Relevant resources
- Error: "Cannot redefine property: Shopify" when run Hydrogen on local #2549
chrome-extension://eppiocemhmnlbhjplcgkofciiegomcon/libs/extend-native-history-api.js- ChatGPT conversation: Ad-blockers and Website Breakage
- Loom video
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels