Check for ::Array, not T_ARRAY in opt_aref #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like that you added a new test. LGTM. |
st0012
pushed a commit
that referenced
this pull request
Dec 18, 2025
…rd-send" This reverts commit ruby/delegate@fc2bd0498af0. ruby/delegate@7d5c1e0842 Co-authored-by: Jean Boussier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
T_ARRAY check was overzealous. BOP flags are only for ::Array. Objects that are array subclasses and ones that have singleton aref can have the
T_ARRAYshape.