Make the finalizer fork safe, and allow for early close#19
Merged
casperisfine merged 1 commit intomasterfrom Dec 15, 2023
Merged
Make the finalizer fork safe, and allow for early close#19casperisfine merged 1 commit intomasterfrom
casperisfine merged 1 commit intomasterfrom
Conversation
takaokouji
added a commit
to speee/schmooze
that referenced
this pull request
Jan 29, 2026
The close() method was calling process_thread.value without first terminating the Node.js process. If the process doesn't exit when stdin is closed (e.g., processes with setTimeout or event listeners), this would hang indefinitely. This fix adds Process.kill(:KILL, pid) before waiting, consistent with the finalizer implementation from PR Shopify#19. Added tests to verify: - Finalizer does not hang with long-running processes - Multiple instances are handled correctly under GC pressure - Fork safety is maintained - close() method does not hang Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This was referenced Jan 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, when leaning solely on the finalizer, if you fork while an instance is in memory, both the parent and the child will try to wait on it, and will likely lock up.