Skip to content

Sorbet error when setting host config to nil in local development #1363

@sle-c

Description

@sle-c

Issue summary

Before opening this issue, I have:

  • Upgraded to the latest version of the package
    • shopify_api version:
    • Ruby version:
    • Operating system:
  • Set log_level: :debug in my configuration, if applicable
  • Found a reliable way to reproduce the problem that indicates it's a problem with the package
  • Looked for similar issues in this repository
  • Checked that this isn't an issue with a Shopify API

The gem raising on local dev with a passed nil into T.must?
When the HOST env var is set where the gem reads, but that env var doesn't contain a protocol, so the gem raises here. For us it's failing on this concern from shopify_app . We can hack around it for now by explicitly setting the host , but it looks like either the gem needs to be updated to support local dev, or dev needs to be updated to include a protocol in the HOST env var?

Expected behavior

host config works without requiring protocol scheme. Maybe setting a default?

Actual behavior

The gem raising on local dev with a passed nil into T.must?

Steps to reproduce the problem

  1. Include FrameAncestor in one of your controller
  2. Set HOST env var as www.example.com without http or https

Debug logs

// Paste any relevant logs here

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions