Add fix for tests on MacOS 12 with -race flag for go17#351
Merged
Conversation
miry
approved these changes
Jan 5, 2022
Contributor
miry
left a comment
miry
left a comment
There was a problem hiding this comment.
Need to update Changelog also - and ❤️
Strech
force-pushed
the
fix-malloc-nano-zone-issue
branch
from
f03df8f to
192c59c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix is already merged in upstream, but yet not released. Change will perform OS and Golang version check and add
MallocNanoZone=0on MacOS with go17 <= 1.17.5 (I hope that 1.17.6 will include upstream fix)Question: Do we want to include other Go versions? Or we consider 1.17 as the main one on MacOS?