feat(signoz): add ability to set labels for signoz ingress

[Vovcharaa]

Summary by CodeRabbit

• New Features

  • Added support for custom labels on SigNoz ingress resources, enabling users to attach custom metadata and tags to their ingress configurations.

• Documentation

  • Updated documentation links and references to reflect current configuration structure in values.yaml.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds support for custom ingress labels to the SigNoz Helm chart by introducing a new signoz.ingress.labels configuration field, updating the ingress template to render these labels conditionally, and correcting documentation anchor links in the README.

Changes

Cohort / File(s)	Summary
Documentation Updates charts/signoz/README.md	Updated documentation table entries with corrected anchor links to values.yaml sections (e.g., signoz.\* and otelCollector.\* field references); added new labels: {} entries under Otel Collector ingress section and other ingress blocks.
Ingress Template Enhancement charts/signoz/templates/signoz/ingress.yaml	Added conditional rendering block to inject signoz.ingress.labels under metadata.labels using toYaml with proper indentation, enabling optional custom labels on the ingress resource.
Values Configuration charts/signoz/values.yaml	Added new signoz.ingress.labels configuration field with default empty object ({}) and accompanying descriptive comments.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Straightforward feature addition with consistent pattern across three files
• No complex logic or control-flow changes; primarily configuration and template additions
• Documentation updates are primarily link corrections and incidental additions

Suggested labels

safe-to-test

Suggested reviewers

• grandwizard28
• prashant-shahi

Poem

🐰 Labels for ingress, now neat and clean,
Through values and templates, a rendering scene,
Documentation aligned with references true,
A fluffy addition for infrastructure crew! 📌

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely describes the primary change: adding the ability to set labels for the SigNoz ingress resource, which is reflected across values.yaml, the ingress template, and documentation updates.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a349bb6 and 8bf06e8.

📒 Files selected for processing (3)

• charts/signoz/README.md (79 hunks)
• charts/signoz/templates/signoz/ingress.yaml (1 hunks)
• charts/signoz/values.yaml (1 hunks)

🧰 Additional context used

🧠 Learnings (4)

📓 Common learnings

Learnt from: Nageshbansal
Repo: SigNoz/charts PR: 766
File: charts/signoz/templates/_postgresql.tpl:28-32
Timestamp: 2025-10-10T09:26:15.055Z
Learning: In the SigNoz Helm chart, the postgres.selectorLabels template intentionally uses `{{ include "signoz.name" . }}` instead of `{{ include "postgres.name" . }}` to maintain consistency with the overall "signoz" app name across all components.

📚 Learning: 2025-10-10T09:26:15.055Z

Learnt from: Nageshbansal
Repo: SigNoz/charts PR: 766
File: charts/signoz/templates/_postgresql.tpl:28-32
Timestamp: 2025-10-10T09:26:15.055Z
Learning: In the SigNoz Helm chart, the postgres.selectorLabels template intentionally uses `{{ include "signoz.name" . }}` instead of `{{ include "postgres.name" . }}` to maintain consistency with the overall "signoz" app name across all components.

Applied to files:

• charts/signoz/values.yaml
• charts/signoz/templates/signoz/ingress.yaml
• charts/signoz/README.md

📚 Learning: 2024-12-16T16:15:01.460Z

Learnt from: prashant-shahi
Repo: SigNoz/charts PR: 565
File: charts/clickhouse/values.yaml:261-264
Timestamp: 2024-12-16T16:15:01.460Z
Learning: In `charts/clickhouse/values.yaml`, the `customStartupProbe`, `customLivenessProbe`, and `customReadinessProbe` configurations are provided for advanced users to specify custom probe types such as HTTP, Exec, TCP, and gRPC.

Applied to files:

• charts/signoz/README.md

📚 Learning: 2024-11-01T05:29:30.302Z

Learnt from: prashant-shahi
Repo: SigNoz/charts PR: 544
File: charts/signoz/templates/schema-migrator/migrations-sync.yaml:16-23
Timestamp: 2024-11-01T05:29:30.302Z
Learning: In `charts/signoz/templates/schema-migrator/migrations-sync.yaml`, the `Sync` ArgoCD hook and `pre-upgrade` Helm hook are intentionally used to maintain consistent behavior and prevent issues with Kubernetes Job cleanup.

Applied to files:

• charts/signoz/README.md

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: test-chart

🔇 Additional comments (3)

charts/signoz/values.yaml (1)

994-996: Correct placement and documentation of new ingress labels field.

The new signoz.ingress.labels field is properly positioned, documented, and defaults to an empty object, making the feature backward-compatible and opt-in.

charts/signoz/templates/signoz/ingress.yaml (1)

11-13: Proper use of Helm templating for conditional label rendering.

The conditional block uses idiomatic Helm patterns (with statement and toYaml) to safely render custom ingress labels with correct indentation. The implementation gracefully handles empty or missing values.

charts/signoz/README.md (1)

594-594: Documentation correctly reflects new ingress labels field.

The README documentation updates are consistent with the new signoz.ingress.labels field. The labels line is properly included in the signoz.ingress table example, and reference links to values.yaml have been updated appropriately.

Also applies to: 486-552

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Vovcharaa]

Hello @Nageshbansal,
Is there anything else to be done for this to move forward?