Repository navigation
[3.0] Lets recent posts be narrowed to a list of boards again - #9713
Merged
live627 merged 1 commit intoOct 1, 2026
Merged
Conversation
?action=recent;boards= was a 500 for any value. Recent::execute() turns the comma separated list into an array of integers, and getBoards() then ran explode() over it a second time, which is a TypeError on an array. The second conversion goes, since the first has already done its job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
?action=recent;boards=…returns a 500 for any value, a single board included:Recent::execute()converts$_REQUEST['boards']from a comma separated list into an array of integers.Recent::getBoards()then converted it a second time withexplode(), which on PHP 8 is aTypeErroron an array. 2.1 did the conversion once, in the equivalent ofgetBoards(); the 3.0 port added the one inexecute()and kept the old one. This removes the second, since the first already leaves exactly what the query needs. The category branch (;c=) was never affected:getBoards()does not convert that one again.The regression test is an HTTP test, because the page is the thing that broke. It asks for one board and for a list of two, and fails with a 500 on both without the change:
Found while building the template snapshot tests in #9712.
Issues References (Fixes|Related|Closes)
Related: #9712
🤖 Generated with Claude Code