[albertlast]

Description

Themes::copy() (Admin → Themes → Modify themes → theme → Copy a template) also works out which of the default theme's language files the theme already has, and whether each could be overwritten:

$entry = Utils::$context['available_language_files'][$langDir->getFilename() . '/' . $fileInfo->getFilename()];
// ...
... ['can_copy'] = is_writable($theme['theme_dir'] . '/languages/' . $entry);

$entry is the array describing the file, not its name, so every visit logs Array to string conversion once per language file the theme has (twice on a stock forum, for the default theme itself), and the path checked is …/languages/Array. It now checks the file it is looking at.

Tests

tests/Integration/Http/ThemeCopyListTest.php opens the page as the administrator and asserts nothing was logged. Run locally on MySQL and PostgreSQL; tests/Integration/Http is not part of the CI run yet.

Not changed here

The language files are only half a feature, and have been since 2.1. template_copy_template() never shows available_language_files, so there is no link to copy one. The copy itself cannot work either: it only accepts a lang_file whose name is a single character each side of a dot, and reads the source from $_REQUEST['template'] instead. 2.1.7 has the same code. Whether to finish it or remove it seems like a separate decision, so this only stops the warning.

#9717 changes the same method, in a different place.

Issues References (Fixes|Related|Closes)

Related: #9717

🤖 Generated with Claude Code