Repository navigation
[3.0] Only says the emails will stop when they will - #9747
Merged
jdarwood007 merged 1 commit intoOct 4, 2026
Merged
jdarwood007 merged 1 commit into
jdarwood007 merged 1 commit into
Conversation
A reply notification ends with "More replies may be posted, but you will not receive any more notifications for this topic until you visit it" when the member asked to be emailed once until they visit. The wording was chosen for any frequency other than "never", so members emailed about every reply were told the emails would stop, and then kept getting them. Board notifications already checked for the right frequency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This was referenced Oct 4, 2026
jdarwood007
pushed a commit
that referenced
this pull request
Oct 31, 2026
The _once reply templates tell the member no more emails will come until they visit the topic. They were chosen for any non-empty frequency, so members who asked for every reply were told that too. Only the first unread reply setting gets them now, as the board branch already does. Backport of #9747. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Members choose how often they are emailed about topics they watch (
msg_notify_pref): every reply (1), the first unread reply only (2), or a daily or weekly digest. The_oncevariants of the reply notification (notification_reply_once,notification_reply_body_once) are meant for 2. They end with:CreatePost_Notifychose the_oncevariant withif (!empty($frequency)), which is true for "every reply" too. So members who asked to be emailed about every reply were told the emails would stop, and then kept receiving them. The board branch a few lines below already checks$frequency == 2. The reply branch now compares againstFREQUENCY_FIRST_UNREAD_MSGthe same way.This has been the case since 2.1.
Testing
tests/Integration/Http/ReplyNotificationTest.phpruns a reply notification throughcron.phpfor a member watching a topic by email, with the mail queue held:Checked on MySQL and PostgreSQL.
Issues References (Fixes|Related|Closes)
🤖 Generated with Claude Code