Repository navigation
[3.0] Does not announce MOVED and MERGED redirection posts - #9748
Merged
jdarwood007 merged 2 commits intoOct 31, 2026
Merged
jdarwood007 merged 2 commits into
jdarwood007 merged 2 commits into
Conversation
Moving a topic can leave a "MOVED:" redirection topic behind, and merging leaves a "MERGED:" post in each topic merged away. Both were posted like any other message, so the old board's watchers were emailed "New Topic: MOVED: ..." and found it in their digest, and the old topic's watchers were told about a new reply, on top of the move or merge notice the real topic's watchers already get. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
5 of 9 tasks
Adds the license header to the test file this adds, and writes the docblock of each new test method in the agreed shape: Expected:, Guards: for a regression, and @link lines for the commit that introduced the bug and for this pull request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: albertlast <mathiaspapealbert@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two moderation actions leave a redirection post behind:
TopicMove2).TopicMerge).Both go through
Msg::create()withsend_notificationsleft at its default oftrue, so they queueCreatePost_Notifylike any member's post:All of that comes on top of the "Topic moved" / "Topic merged" notice that
sendNotifications()already sends the real topic's watchers. A redirection post only points elsewhere, so both now passsend_notifications => false.This has been the case since 2.1.
Testing
tests/Integration/Http/MoveTopicTest.phpcreates a second board, posts a topic as admin, and moves it there with a redirection topic, through the forms. It checks that the redirection topic exists and that no notification task was queued for it. Without the fix aCreatePost_Notify"topic" task for "MOVED: …" is queued. The test removes its topics and board afterwards. Checked on MySQL and PostgreSQL.The merge half is not covered: driving the merge form needs its options step, and the change there is the same one-line flag.
Issues References (Fixes|Related|Closes)
🤖 Generated with Claude Code